Added a few items for user #1027
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enjoy!
Added canvas primitive shapes Added check if color exists
Added canvas primitive shapes Added check if color exists
Added canvas primitive shapes Added check if color exists
OneAndOnlyFinbar
requested changes
Mar 1, 2024
Comment on lines
+33
to
+34
| if (isValidHexColorCode(colorCode)) result = true; | ||
| else result = false; |
There was a problem hiding this comment.
Having a separate function to check if its valid isn't necessary if its only used once. You can still separate the regex variable for readability but I would recommend the following snippet of code.
const result = /^#(?:[0-9a-fA-F]{3}){1,2}$/.test(colorCode);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Added json formatting. This can be used for Storage that is more readable or for nesting data!
Added primitive shapes mod
Added a check if hex code exists mod
Status
Semantic versioning classification: